fix: fix possible composite key collision in StubDatabaseAdapter test utility#613
Merged
wschurman merged 1 commit intoMay 21, 2026
Conversation
This was referenced May 14, 2026
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 109 109
Lines 17743 17743
Branches 1524 932 -592
==========================================
Hits 17743 17743
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ide
approved these changes
May 15, 2026
quinlanj
approved these changes
May 15, 2026
wschurman
force-pushed
the
05-14-chore_update_comment_for_ientitymetricsadapter_for_implementors
branch
from
925c810 to
e5683e6
Compare
wschurman
force-pushed
the
05-14-fix_fix_possible_composite_key_collision_in_stubdatabaseadapter_test_utility
branch
from
fb9f279 to
7cdf562
Compare
Member
Author
Merge activity
|
wschurman
changed the base branch from
05-14-chore_update_comment_for_ientitymetricsadapter_for_implementors
to
graphite-base/613
wschurman
force-pushed
the
05-14-fix_fix_possible_composite_key_collision_in_stubdatabaseadapter_test_utility
branch
from
7cdf562 to
37e1b88
Compare
wschurman
deleted the
05-14-fix_fix_possible_composite_key_collision_in_stubdatabaseadapter_test_utility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The stub adapters were doing a simple
:join, so it was possible for two rows to collide in the stub adapter during tests, if value has the delimiter.How
Fix is to use JSON.stringify so that only truly same rows map to the same thing.
Test Plan
Run new tests.